search

servo / gecko-media

Firefox's media playback stack in a stand alone Rust crate
Mozilla Public License 2.0
6 stars 9 forks source link

Video player #89

Closed philn closed 6 years ago

philn commented 6 years ago

On behalf of @cpearce :)

philn commented 6 years ago

Another improvement we can add later maybe: resize the window according to original video dimensions present in metadata.

cpearce commented 6 years ago

I have updated the PR to address @glennw's comments.

@nox r?

bors-servo commented 6 years ago

:umbrella: The latest upstream changes (presumably #88) made this pull request unmergeable. Please resolve the merge conflicts.

nox commented 6 years ago

@bors-servo r+

bors-servo commented 6 years ago

:pushpin: Commit 6e128ac has been approved by nox

bors-servo commented 6 years ago

:hourglass: Testing commit 6e128ac51752e20134889bffec511dac8f106ddf with merge 96aa3b873f70b8a27765d3e8941c36d52dc7e9c6...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: nox Pushing 96aa3b873f70b8a27765d3e8941c36d52dc7e9c6 to master...