search

servo / gleam

Generated OpenGL bindings and wrapper for Servo.
Other
83 stars 58 forks source link

Work around a crash in some GL drivers. #185

Closed gw3583 closed 5 years ago

gw3583 commented 5 years ago

When the Mali graphics debugger interceptor library is active, calling glGetShaderInfoLog with a max length of 0 results in a null pointer dereference and thus a crash inside the intercept library.

We can work around this by early exiting from the log functions if the reported log length is 0.

This change is Reviewable

gw3583 commented 5 years ago

r? @kvark or @jrmuizel

jrmuizel commented 5 years ago

@bors-servo r+

bors-servo commented 5 years ago

@jrmuizel: :key: Insufficient privileges: Not in reviewers

jdm commented 5 years ago

@bors-servo r=jrmuizel

bors-servo commented 5 years ago

:pushpin: Commit b70eeda has been approved by jrmuizel

kvark commented 5 years ago

This will conflict with #186 upon landing, since both bump the patch version

bors-servo commented 5 years ago

:hourglass: Testing commit b70eedaf7d01db72bbe020e84101c034b7cba7e9 with merge a28277bf5d0c433b0fad1a55189ac76d09655008...

bors-servo commented 5 years ago

:sunny: Test successful - checks-travis Approved by: jrmuizel Pushing a28277bf5d0c433b0fad1a55189ac76d09655008 to master...

kvark commented 5 years ago

This will conflict with #186 upon landing, since both bump the patch version

Underestimated the wit of git conflict resolver :) :tada: