servo / gleam

Generated OpenGL bindings and wrapper for Servo.
Other
84 stars 58 forks source link

Expose vertex array object extension API #199

Closed jdm closed 5 years ago

jdm commented 5 years ago

This is needed in order to solve https://github.com/servo/servo/issues/23960. There's no way to transparently fall back to the APPLE method from the existing API because they are loaded in non-legacy GL contexts on macOS but point to the very unhelpful glInvalidFunction API and cause a crash.


This change is Reviewable

jdm commented 5 years ago

Yeah, I keep thinking we should look into gfx-rs to see if these kinds of issues are dealt with for us. @bors-servo r=asajeffrey

jdm commented 5 years ago

Huh, no bors for this repo.

jdm commented 5 years ago

@bors-servo r=asajeffrey

bors-servo commented 5 years ago

:pushpin: Commit e207cff has been approved by asajeffrey

bors-servo commented 5 years ago

:hourglass: Testing commit e207cff3f52d630946a058edde0a35d6a33ad671 with merge 5e61d11fdf9857956479282a2d48fcce169f79c2...

bors-servo commented 5 years ago

:sunny: Test successful - checks-travis Approved by: asajeffrey Pushing 5e61d11fdf9857956479282a2d48fcce169f79c2 to master...