search

servo / gleam

Generated OpenGL bindings and wrapper for Servo.
Other
84 stars 58 forks source link

Please make a version break every time you add functions to the `Gl` trait #200

Closed fschutt closed 5 years ago

fschutt commented 5 years ago

I've now gotten this error here: https://github.com/maps4print/azul/issues/203#issuecomment-526901138 - which happens because I have a custom implementation of the Gl trait for providing a "virtual" OpenGL driver for unit-testing purposes. gleam 0.6.20 added three new functions; gen_vertex_arrays_apple, delete_vertex_arrays_apple, bind_vertex_array_apple. You can close this issue if you've read it, but I just wanted to say it - cargo relies on semantic versioning to be done properly and this is at least the fifth time that my code breaks because some dependency didn't stick to semver. Sadly, I'm not able to lock down the version of gleam for a library if gleam doesn't adhere to semver, because cargo ignores Cargo.lock files of libraries. While this is more of a problem with cargo, for the meantime it would be nice to not release new versions of gleam under 0.6 if they aren't actually compatible with the old Gl trait.

jdm commented 5 years ago

Whoops. Apologies for the semantically-invalid version.

nox commented 5 years ago

Let's yank 0.6.20 and release 0.7.

jdm commented 5 years ago

Yanked.