allow implementation of Gl trait outside of crate

servo / gleam

Generated OpenGL bindings and wrapper for Servo.

Other

83 stars 58 forks source link

allow implementation of Gl trait outside of crate #210

Closed lsalzman closed 4 years ago

lsalzman commented 4 years ago

Firefox's software WebRender implementation requires the ability to implement the Gl trait from outside the crate so that we can pass it off to WebRender as an OpenGL implementation.

PR #207 broke this for us so we're currently blocked on this issue for integrating it into Firefox.

jdm commented 4 years ago

@bors-servo r+

bors-servo commented 4 years ago

:pushpin: Commit d0b437e has been approved by jdm

bors-servo commented 4 years ago

:hourglass: Testing commit d0b437e9be4970c4b838e99375c6c601823a4685 with merge 34e8257e23fd6112cc3d5ad90623f3c2177e5808...

bors-servo commented 4 years ago

:sunny: Test successful - checks-travis Approved by: jdm Pushing 34e8257e23fd6112cc3d5ad90623f3c2177e5808 to master...

nox commented 4 years ago

This is bad, now any change to the trait is a breaking change again. :/

jdm commented 4 years ago

Yes, but it was reverted in order to support implementing the trait outside of the gleam crate. Servo barely depends on gleam any longer so it's not a problem for us.

nox commented 4 years ago

Also this should have been a non-breaking change, in this PR.