Highfive intelligence treatment: basics to find intermittents

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Highfive intelligence treatment: basics to find intermittents #100

Closed wafflespeanut closed 7 years ago

wafflespeanut commented 8 years ago

This should help in showing known intermittents next to the logs if we find a matching file in the title of issues tagged under "I-intermittent".

@jdm I wasn't sure about testing this initially, because we don't have a handler (and hence, a test) that fiddles around the payload response for a search query (currently, all our handlers work on PRs). So, I went ahead and crafted one for the sake of testing this. Realistically, when we query something, the API returns something similar to what we have in payload['search'].

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/homu_status/init.py, handlers/homu_status/tests/json/builders/test_stdio, test.py, handlers/homu_status/tests/intermittents.json, newpr.py

bors-servo commented 8 years ago

:umbrella: The latest upstream changes (presumably #107) made this pull request unmergeable. Please resolve the merge conflicts.

highfive commented 8 years ago

New code was committed to pull request.

wafflespeanut commented 8 years ago

Sorry, I'd totally forgotten about this :)

(Note that this is rebased on top of #129)

highfive commented 8 years ago

New code was committed to pull request.

highfive commented 8 years ago

New code was committed to pull request.

wafflespeanut commented 8 years ago

This is ready for review!

bors-servo commented 8 years ago

:umbrella: The latest upstream changes (presumably 614fc22) made this pull request unmergeable. Please resolve the merge conflicts.

jdm commented 7 years ago

Given our extra build step that filters out intermittents, I guess this work isn't necessary any longer.