Allow users not present in collaborators.ini to be assigned

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Closed jdm closed 8 years ago

jdm commented 8 years ago

collaborators.ini is a subset of the people with review privileges, so it's not enough to validate potential assignees against it.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

bors-servo commented 8 years ago

:umbrella: The latest upstream changes (presumably #107) made this pull request unmergeable. Please resolve the merge conflicts.

wafflespeanut commented 8 years ago

What happens when a non-owner approves a PR? Github doesn't allow assigning them, right?

jdm commented 8 years ago

Correct.

highfive commented 8 years ago

New code was committed to pull request.

wafflespeanut commented 8 years ago

Looks good to me! :)