servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Mozilla Public License 2.0
254 stars 58 forks source link

tests should only be run against the associated handler #117

Closed numberMumbler closed 8 years ago

numberMumbler commented 8 years ago

currently, handlers' tests are not isolated: every handler is run for each test. This causes problems (for example) when checking comment counts in a test result, because multiple handlers might add comments

jdm commented 8 years ago

We could probably support this by making get_handlers take an argument that is used to filter the resulting handlers that are discovered?

numberMumbler commented 8 years ago

I ended up adding it to the test setup, since both the handler and test were accessible at that point. Let me know if you'd like any changes