search

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Mozilla Public License 2.0
254 stars 58 forks source link

Find ways to avoid hitting the API limit #124

Open jdm opened 8 years ago

jdm commented 8 years ago

Possibly alternate between two accounts for each time the webhook is invoked?

jdm commented 8 years ago

It would be useful to log times when we hit the API limit, too.

wafflespeanut commented 8 years ago

Could this be behind #110 and #112, since we don't know what else is causing such "unpredictability"?

jdm commented 8 years ago

I don't see how it could be responsible for #112.

wafflespeanut commented 8 years ago

Okay, I (must've) misread it. It shouldn't cause #112

wafflespeanut commented 8 years ago

Are we currently going for all events? Because, then, we could associate some set of events to an account - say pull_request for "highfive" and issue for "highfive-2"?

jdm commented 8 years ago

There's no account associated with receiving events. Highfive is in control of which account details are used with each API request it makes.

wafflespeanut commented 8 years ago

This pops in often these days :sob:

jdm commented 8 years ago

Note: rate limit responses look like a 403 Forbidden response code, with an x-ratelimit-remaining header with value 0, with a JSON response with a message field that states that the rate limit was exceeded.