Add S-needs-code-changes if travis build fails - Githubissues

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Add S-needs-code-changes if travis build fails #133

Open wafflespeanut opened 8 years ago

wafflespeanut commented 8 years ago

This is a rebase of #88.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/status_update/init.py, travisciapiprovider.py, eventhandler.py, handlers/status_update/tests/build_status.json, newpr.py

highfive commented 8 years ago

New code was committed to pull request.

highfive commented 8 years ago

New code was committed to pull request.

highfive commented 8 years ago

New code was committed to pull request.

highfive commented 8 years ago

New code was committed to pull request.

highfive commented 8 years ago

New code was committed to pull request.

wafflespeanut commented 8 years ago

@jdm I'm not sure whether you're gonna like this, because I couldn't find a way to have a module for TravisCiApiProvider without a circular dependency (and test it at the same time) without duplicating code (especially because it should be initialized at extract_globals_from_payload).

The easier solution was to integrate extract_globals_from_payload and the travis payload parsing into APIProvider itself, so that we can reuse the methods whenever we want.

bors-servo commented 8 years ago

:umbrella: The latest upstream changes (presumably #125) made this pull request unmergeable. Please resolve the merge conflicts.