Do not notify watcher when watcher is PR author (fixes issue #128)

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Closed atelierJVA closed 8 years ago

atelierJVA commented 8 years ago

In /handlers/watchers/init.py check user:{login:} against watcher for a file/directory
Added a new test, new_pr_author_is_watcher.json with test_user as the PR author; Assumed that a file/directory will only have 1 watcher, otherwise some tests would fail.
Modified the existing test to include the :user and :login in the payload; Renamed to new_pr_author_not_a_watcher.json

highfive commented 8 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/watchers/init.py, handlers/watchers/tests/new_pr.json, handlers/watchers/tests/new_pr_author_is_watcher.json, handlers/watchers/tests/new_pr_author_is_not_watcher.json

wafflespeanut commented 8 years ago

flake8 error should be fixed for Travis build to pass. Otherwise, LGTM :)

highfive commented 8 years ago

New code was committed to pull request.

jdm commented 8 years ago

Thank you!