unescape HTML entities in test failure output

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

unescape HTML entities in test failure output #140

Closed Nebopolis closed 8 years ago

Nebopolis commented 8 years ago

fixes #94

highfive commented 8 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/homu_status/init.py

KiChjang commented 8 years ago

Is there a way to test these changes?

wafflespeanut commented 8 years ago

@KiChjang The current design of highfive's testsuite only checks the number of comments for a particular handler at the end of each test, not the contents they have (I'm planning to implement it someday soon).

Nebopolis commented 8 years ago

@KiChjang I'm not sure. The existing test only checks for the presence of a comment.

wafflespeanut commented 8 years ago

Squash the commits and we'll be good to go!

wafflespeanut commented 8 years ago

Thanks for doing this work! :)