Don't warn if files with tests for bindings are modified

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Don't warn if files with tests for bindings are modified #153

Closed flacerdk closed 8 years ago

flacerdk commented 8 years ago

I can't say I really understood how the tests work--hard to tell what's being tested when there's no live repository--, but I went ahead and added one anyway. Fixes #49.

highfive commented 8 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/missing_test/init.py, handlers/missing_test/tests/test_binding.json

jdm commented 8 years ago

Thanks for doing this! The test is checking the right thing, so thanks for adding it.

flacerdk commented 8 years ago

Great! I'll add the other files, then.

wafflespeanut commented 8 years ago

Looking good. Can you please squash the commits?

flacerdk commented 8 years ago

Done!

jdm commented 8 years ago

Thanks!