search

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Mozilla Public License 2.0
254 stars 58 forks source link

Assign reviewer as a 'reviewer' instead of 'assignee' #162

Open frewsxcv opened 7 years ago

frewsxcv commented 7 years ago

https://github.com/blog/2291-introducing-review-requests

jdm commented 7 years ago

I'm only interested in making this happen if we can filter lists of PRs by the reviewer like https://github.com/servo/servo/pulls?q=is%3Aopen+is%3Apr+label%3AS-awaiting-review+assignee%3Ajdm .

frewsxcv commented 7 years ago

Agreed. I realized that wasn't possible until after I opened this.

tetsuharuohzeki commented 7 years ago

I'm only interested in making this happen if we can filter lists of PRs by the reviewer like

Now, we can filter it by https://github.com/blog/2306-filter-pull-request-reviews-and-review-requests

jdm commented 7 years ago

The other important consideration is whether the github API allows filtering by review requests, since http://www.joshmatthews.net/who-reviews-the-reviewers/ relies on that feature.