Check if compile-fail tests are modified

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Check if compile-fail tests are modified #167

Closed jdm closed 7 years ago

jdm commented 7 years ago

Our missing_tests handler warns if changes are made to Servo without corresponding automated tests. Sometimes we get false positives like https://github.com/servo/servo/pull/15146 because the compile-fail directory is not checked right now. We should fix this and add an automated test to tests/new_pr.json.

highfive commented 7 years ago

Please make a comment here if you intend to work on this issue. Thank you!

DexterHaslem commented 7 years ago

I'd like to work on this

jdm commented 7 years ago

Please do! Ask questions if anything is unclear :)

jdm commented 7 years ago

Fixed by #168.