also check 'compiletest/plugin/compile-fail' test dir on a new PR

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

also check 'compiletest/plugin/compile-fail' test dir on a new PR #168

Closed DexterHaslem closed 7 years ago

DexterHaslem commented 7 years ago

This addresses issue #167 - Let me know if you'd rather not slam the entire sub-dir path in TEST_DIRS_TO_CHECK and instead do something like COMPILE_TEST_DIRS_TO_CHECK

highfive commented 7 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

highfive commented 7 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/missing_test/init.py, handlers/missing_test/tests/new_pr.json

jdm commented 7 years ago

This looks fine; we just need to fix the flake8 error that travis reports before merging:

$ flake8 .
./handlers/missing_test/__init__.py:11:80: E501 line too long (82 > 79 characters)
The command "flake8 ." exited with 1.

DexterHaslem commented 7 years ago

Apologize for forgetting to flake. I ran my IDE integrated PEP8 linter and it removed many trailing spaces, If I committed a lot of whitespace changes would that be a big deal?

jdm commented 7 years ago

If they stay as a separate commit, that sounds fine.

jdm commented 7 years ago

@bors-servo: r+

bors-servo commented 7 years ago

:pushpin: Commit 770e95b has been approved by jdm

bors-servo commented 7 years ago

:zap: Test exempted - status