Check if self.token is present

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Check if self.token is present #177

Closed Sriharivignesh closed 7 years ago

Sriharivignesh commented 7 years ago

Instead of checking if token is present in which case Python searches for a global variable named 'token' and errors out.

highfive commented 7 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @wafflespeanut (or someone else) soon.

highfive commented 7 years ago

Heads up! This PR modifies the following files:

@jdm: newpr.py

jdm commented 7 years ago

@bors-servo: r+ Weird! Thanks for the fix!

bors-servo commented 7 years ago

:pushpin: Commit 6a3a1a6 has been approved by jdm

bors-servo commented 7 years ago

:hourglass: Testing commit 6a3a1a600c884d910144e4ebc661a6da1e516fce with merge 5a21c889cdcdc67df06aa5fc62ddea70e901e963...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis Approved by: jdm Pushing 5a21c889cdcdc67df06aa5fc62ddea70e901e963 to master...