add me to watching things; alphebetize lists

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

add me to watching things; alphebetize lists #182

Closed edunham closed 7 years ago

edunham commented 7 years ago

I would like to watch some things.

I also went :sort on the lists to which I added myself, so that future additions can be done with a less noisy diff.

highfive commented 7 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/watchers/watchers.ini, handlers/label_watchers/watchers.ini

jdm commented 7 years ago

Bah, https://github.com/servo/highfive/blob/master/handlers/label_watchers/tests/dont_annoy.json was written without using test-only data so it no longer passes with these additional changes.

edunham commented 7 years ago

Testing works in mysterious ways. I poked the test to make it not fail with the current watcher lists. I'm not totally sure if that was the right fix, and it seems like it's almost certainly not the best fix, but it does appear to be a fix for the problem at hand.

canova commented 7 years ago

FYI, I filed a PR to use test data instead of real repo data(#184). You can revert that test change after that probably.

bors-servo commented 7 years ago

:umbrella: The latest upstream changes (presumably #184) made this pull request unmergeable. Please resolve the merge conflicts.

jdm commented 7 years ago

Rebased the important parts in #185. Sorry about the delay.

edunham commented 7 years ago

Thanks!