servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Mozilla Public License 2.0
254 stars 58 forks source link

add unassign to hivefive #199

Closed tigercosmos closed 6 years ago

tigercosmos commented 6 years ago

we can assign ourselves, but we can't unassign later when we find cannot handle the issue.

KiChjang commented 6 years ago

I'm unclear on the benefits of this would have over commenting "please unassign me from this issue" and then have a reviewer remove the tag.

tigercosmos commented 6 years ago

yeah. We can let reviewer to do that. But if the bot can do, why not? :)

KiChjang commented 6 years ago

Because the bot cannot do what you think it does, the label does not carry any information about who said @highfive assign me before, and if you implement it naively, the bot would just remove the label whenever someone comments @highfive unassign me.

tigercosmos commented 6 years ago

@KiChjang You are right .. This still can be solve by checking comment above, but it will be too complicated.

wafflespeanut commented 6 years ago

@tigercosmos This would be an interesting feature for the new highfive (which tracks assignees). I've opened it there :)

tigercosmos commented 6 years ago

@wafflespeanut Ah! What's the new highfive? Will it replace the current one soon?

wafflespeanut commented 6 years ago

@tigercosmos It was planned for a replacement last year, but it's currently being blocked on an issue with Github itself. Once that's resolved, we'll probably switch to it :)

I also need to clean it up a bit - right now, it's a giant monolithic hog'ish nightmare which just works.

tigercosmos commented 6 years ago

I see. Once it launch, I would like to contribute on it. :)

wafflespeanut commented 6 years ago

Sure thing!