servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Mozilla Public License 2.0
254 stars 58 forks source link

Warn if non-ini files are added to tests/wpt/metadata/ or tests/wpt/mozilla/meta/ #43

Closed jdm closed 8 years ago

jdm commented 8 years ago

This would entail a new handler which looks at the new PR's diff (via get_diff in on_new_pr), finds a before path of /dev/null, and an after path that matches one of the metadata directory paths with a file extension that is not .ini.

g-k commented 8 years ago

hrm, this should ignore changes to MANIFEST.json as in https://github.com/servo/servo/pull/9737

jdm commented 8 years ago

Yeah, that's #59.