Auto-assign collaborator for review when not specified in PR body

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Auto-assign collaborator for review when not specified in PR body #63

Closed magni- closed 8 years ago

magni- commented 8 years ago

Diff minus #61: https://github.com/servo/highfive/compare/9403b90...715ccdd

Fixes: #40

Rather than choose at random, this iterates over a list of collaborators. Is an ini file the best way to define these?

highfive commented 8 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @test_user_selection_ignore_this (or someone else) soon.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/missing_test/tests/new_pr.json, handlers/status_update/tests/new_pr.json, handlers/assign_reviewer/init.py, handlers/unsafe/tests/new_pr.json, handlers/no_modify_css_tests/tests/new_pr.json, handlers/welcome/init.py, handlers/watchers/tests/new_pr.json, handlers/assign_reviewer/tests/new_pr_without_reviewer.json, collaborators.ini, handlers/nonini_wpt_meta/tests/new_pr.json, handlers/welcome/tests/new_pr.json, handlers/assign_reviewer/tests/new_pr_with_reviewer.json

KiChjang commented 8 years ago

I'm kinda sad that my name isn't in the collaborators.ini file.

KiChjang commented 8 years ago

Here's the current list of reviewers: https://github.com/servo/saltfs/blob/master/homu/cfg.toml#L63

magni- commented 8 years ago

Sorry :( I copied what was in the welcome handler...

magni- commented 8 years ago

Ugh what did I just do... past midnight here, I'll fix this tomorrow.

jdm commented 8 years ago

Ok! This looks like it's ready to merge, so I'll probably go ahead and cherry-pick the right commits. Thanks!

magni- commented 8 years ago

Ahh thanks! Should be just the last three

jdm commented 8 years ago

Merged as c58f22be34e78493a0260934c12bcf3ab86f24a1. Thanks!