add testbinding.rs and TestBinding.webidl to check list

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

add testbinding.rs and TestBinding.webidl to check list #68

Closed Conjuror closed 8 years ago

Conjuror commented 8 years ago

PR for fix issue #49

highfive commented 8 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/missing_test/init.py

jdm commented 8 years ago

Thank you for working on this, and I apologize for forgetting about this PR. Unfortunately, if we add a test for this change we'll see that it won't pass, since the paths to the TestBinding.webidl and testbinding.rs files aren't matched correctly. Take a look at https://patch-diff.githubusercontent.com/raw/servo/servo/pull/10355.diff, which is the diff of a PR that modifies both of those files.

jdm commented 8 years ago

Closing due to lack of updates.