Fold welcome into assign_reviewer.

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Fold welcome into assign_reviewer. #90

Closed zbynekwinkler closed 8 years ago

zbynekwinkler commented 8 years ago

The two handlers had separate logic to pick a reviewer resulting in a different person mentioned in the welcome message for a new contributor from the assignee on the PR. See https://github.com/servo/highfive/issues/83

highfive commented 8 years ago

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

highfive commented 8 years ago

Heads up! This PR modifies the following files:

@jdm: handlers/welcome/tests/new_pr.json, handlers/welcome/init.py, handlers/assign_reviewer/init.py, handlers/assign_reviewer/tests/welcome.json

jdm commented 8 years ago

Thanks!