Assign reviewers to PRs when they approve

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors

Mozilla Public License 2.0

254 stars 58 forks source link

Closed wafflespeanut closed 8 years ago

wafflespeanut commented 8 years ago

fixes #66

This should work for stuff like r+ or r=username (I've done some minor cleanup along with that)

highfive commented 8 years ago

Heads up! This PR modifies the following files:

wafflespeanut commented 8 years ago

~~Oops, forgot to add the test.~~

wafflespeanut commented 8 years ago

The test JSONs look very big, and it feels a bit awkward to see that most of the key/vals are not even necessary for the tests :/

jdm commented 8 years ago

Yeah, I thought it was clever because I could just paste full JSON dumps of real github hooks, but it's really not great for reading comprehension.

jdm commented 8 years ago

Thanks!

wafflespeanut commented 8 years ago

Oh please... That makes me a newcomer! Don't you think it's too formal? :smile:

jdm commented 8 years ago

wafflespeanut commented 8 years ago

Um, this hasn't happened before. Now, should I open a new PR with the changes?