search

servo / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Mozilla Public License 2.0
254 stars 58 forks source link

Unescape HTML when reading test expectations #94

Closed emilio closed 8 years ago

emilio commented 8 years ago

Right now if the comment contains HTML, it's sent to github escaped, which makes things like the 'new' you see in https://github.com/servo/servo/pull/10819#issuecomment-213735708 appear.

Ms2ger commented 8 years ago

We should not be reading HTML at all, now that we have structured logs with a summary of the errors.

wafflespeanut commented 8 years ago

That was the original intent, but we don't have all the necessary info in the structured log.

Currently, it shows only the test name and the expected/unexpected results (along with a lot of stackwalk_stdout stuff).

highfive commented 8 years ago

cc @jdm

highfive commented 8 years ago

Please make a comment here if you intend to work on this issue. Thank you!

wafflespeanut commented 8 years ago

We can use the built-in HTMLParser for doing the unescaping.

Code: handlers/homu_status/__init__.py

Nebopolis commented 8 years ago

I would like to work on this issue.

wafflespeanut commented 8 years ago

Great to know! Please go ahead :)