search

servo / homu

A bot that integrates with GitHub and your favorite continuous integration service
MIT License
329 stars 48 forks source link

Add support for try=chooser syntax #167

Closed Manishearth closed 6 years ago

Manishearth commented 6 years ago

Adds support for try choosers in the configuration.

SQLite migration notes: Either start from a fresh db, or run ALTER TABLE pull ADD try_choose text

This change is Reviewable

Manishearth commented 6 years ago

So homu doesn't actually kick off these builds -- buildbot does. Homu just waits for completion pings for these builds.

So we need to add a SingleBranchScheduler for branches named try-foo and try-bar. Does this sound ok?

Manishearth commented 6 years ago

This was tested in https://github.com/servo/servo/pull/21300 , seemed to work reasonably well. Ignore the initial r-s, that's me attempting to recoup homu state after running this without a correctly updated buildbot (which leads to homu waiting forever for a build which was never kicked off)

Manishearth commented 6 years ago

r? @jdm

jdm commented 6 years ago

@bors-servo r+

bors-servo commented 6 years ago

:pushpin: Commit b26895f has been approved by jdm

bors-servo commented 6 years ago

:hourglass: Testing commit b26895f24cee7ba60df1e3692d923e6830076b1b with merge ca6ba9605d6506edc74b98f95cdac62bbfc5deea...

bors-servo commented 6 years ago

:sunny: Test successful - status-travis Approved by: jdm Pushing ca6ba9605d6506edc74b98f95cdac62bbfc5deea to master...