servo / html5ever

High-performance browser-grade HTML5 parser
Other
2.1k stars 215 forks source link

tests fail under rust 1.77.1 to build because of rustc-test #526

Closed rillian closed 5 months ago

rillian commented 5 months ago

cargo test fails to build under rust 1.77.1 because of the rustc-test transitive dependency on rustc-serialize. Looks like this is already reported upstream, but I expect the whole crate is no longer necessary and the dependency can removed.

rillian commented 5 months ago

The inclusion in xml5ever isn't used; it looks like the depending code was moved to markup5ever in 7e87faff0c9b28fbb4a1378b871bdc4c5e518c73.

It's still used in rcdom as a harness for running tests based on runtime discovery of test suite files. There are newer crates which support this, and rustc-test is also a servo project, so that could also be updated. But since it's testing the public api, I suggest just replacing it with some logging.