(If html5ever does not have these attributes defined in local_names.txt, then changes to element.rs such as this fail to compile.)
This PR adds the missing ARIA attributes:
aria-braillelabel
aria-brailleroledescription
aria-colcount
aria-colindex
aria-colindextext
aria-colspan
aria-current
aria-description
aria-details
aria-errormessage
aria-keyshortcuts
aria-label
aria-modal
aria-orientation
aria-placeholder
aria-roledescription
aria-rowcount
aria-rowindex
aria-rowindextext
aria-rowspan
aria-valuetext
However, I did not remove the currently-defined ARIA attributes which are not available in ARIAMixin:
aria-channel
aria-datatype
aria-dropeffect
aria-grab
aria-relevant
aria-secret
aria-templateid
I assume these are deprecated/nonstandard, but I don't see a strong reason to remove them since I'm not sure if any downstream code is relying on them. (Update: it turns out the WPT tests still reference aria-relevant.)
BTW I did not find any tests for the existing aria-* attributes, but I'd be happy to add them as necessary.
As part of implementing
ARIAMixin
(https://github.com/servo/servo/issues/32079), it seems that, as a first step,html5ever
would need to update its list of ARIA attributes inlocal_names.txt
to correspond to those defined inARIAMixin
.(If
html5ever
does not have these attributes defined inlocal_names.txt
, then changes toelement.rs
such as this fail to compile.)This PR adds the missing ARIA attributes:
However, I did not remove the currently-defined ARIA attributes which are not available in
ARIAMixin
:I assume these are deprecated/nonstandard, but I don't see a strong reason to remove them since I'm not sure if any downstream code is relying on them. (Update: it turns out the WPT tests still reference
aria-relevant
.)BTW I did not find any tests for the existing
aria-*
attributes, but I'd be happy to add them as necessary.