servo / html5ever

High-performance browser-grade HTML5 parser
Other
2.14k stars 222 forks source link

fix(local_names): add missing ARIA attributes #536

Closed nolanlawson closed 6 months ago

nolanlawson commented 6 months ago

As part of implementing ARIAMixin (https://github.com/servo/servo/issues/32079), it seems that, as a first step, html5ever would need to update its list of ARIA attributes in local_names.txt to correspond to those defined in ARIAMixin.

(If html5ever does not have these attributes defined in local_names.txt, then changes to element.rs such as this fail to compile.)

This PR adds the missing ARIA attributes:

However, I did not remove the currently-defined ARIA attributes which are not available in ARIAMixin:

I assume these are deprecated/nonstandard, but I don't see a strong reason to remove them since I'm not sure if any downstream code is relying on them. (Update: it turns out the WPT tests still reference aria-relevant.)

BTW I did not find any tests for the existing aria-* attributes, but I'd be happy to add them as necessary.