servo / intermittent-tracker

A live database of intermittent test failures based on github's webhook notifications.
https://build.servo.org/intermittent-tracker/query.py?name=
Mozilla Public License 2.0
3 stars 12 forks source link

Most-flaky: added a GitHub issue link to corresponding test in most-flaky view #18

Closed azharcodeit closed 8 months ago

azharcodeit commented 8 months ago

Context:

The most-flaky view lists each test, but it would be useful to have a link to the corresponding GitHub issue for each of those tests.

Changes made:


azharcodeit commented 8 months ago

This looks great. Just a small request to integrate this into the main column. Thank you and sorry for not having a clearer description of what I was imagining beforehand.

Yes, sure, no problem at all! I'll take care of integrating it into the main column later today or tomorrow. Thank you

azharcodeit commented 8 months ago

This looks great. Just a small request to integrate this into the main column. Thank you and sorry for not having a clearer description of what I was imagining beforehand.

I've made the changes as per your feedback. Could you please review and confirm if this is what you had in mind regarding the integration of the GitHub issue column? I want to ensure that I understood your feedback correctly. If not, please let me know the intended location for the integration.

If you meant adding this column to the recent unexpected results page, I attempted it, but it resulted in a significant increase in page load time, taking about 50-60 seconds. Due to this, I assumed it wasn't the desired location for the integration. If this is the case, I'm considering an alternative approach to improve performance by creating an issues table based on the issues.json file. This could potentially lead to faster loading times.

azharcodeit commented 8 months ago

Looks good, with one minor change requested.

Apologies for the oversight, forgot to test it out first with several issues