search

servo / media

Mozilla Public License 2.0
82 stars 53 forks source link

Update ipc-channel to 0.16 #395

Closed mukilan closed 1 year ago

mukilan commented 1 year ago

ipc-channel used in servo needs to bumped to 0.16.1 to complete https://github.com/servo/servo/issues/29467, but that requires the same version to be used by media crates as well.

FYI: I had accidentally pushed my change to master branch of this repo. I've now force pushed master to it's previous state. I've also made 'master' a protected branch. Please let me know if that needs to be changed or removed.

jdm commented 1 year ago

This looks fine, but apparently webrender no longer builds on nightly rust :(

mukilan commented 1 year ago

@jdm looks like only the example code uses webrender, specifically v0.60.0 which is quite old and the offending code has been removed in servo/webrender@e8d2d7d6

I am able to build and run servo master with latest ipc-channel (plus your patch and another small change to account for the renaming of drain_filter nightly feature flag.

Do you think we should first publish webrender 0.62.0 and update the failing examples or should we merge this PR now and fix the examples in a new issue?

cc @mrobinson as you know more about webrender

jdm commented 1 year ago

Ah, if it's just example code than I'm less concerned. I'm ok with merging and fixing up the example separately.

mukilan commented 1 year ago

I've created this issue to update the example with new webrender.

I'll merge this PR manually for now.