Speed up mozangle build on Windows

servo / mozangle

Mozilla’s fork of Google ANGLE, repackaged as a Rust crate

Other

42 stars 23 forks source link

Closed mrobinson closed 1 year ago

mrobinson commented 1 year ago

The source of angle was being compiled into each DLL even though the angle.lib file was passed as an argument to the compiler.
When compiling on Visual Studio cl the /MP argument enables parallel compilation. This is still serial on clang-cl.exe unfortunately.
Make the build.rs file more resilient when passing different options. Notably, build_dlls and egl now produce an error on any other platform than Windows.
Update the version.

mrobinson commented 1 year ago

This seems to drop Windows CI times from 30 minutes to 10.

jdm commented 1 year ago

@bors-servo r+

bors-servo commented 1 year ago

:pushpin: Commit a5125d9 has been approved by jdm

bors-servo commented 1 year ago

:hourglass: Testing commit a5125d9e3fa767dcdd6d58326aae86d8239acf9a with merge 235cf2b1c7a25bdac61b240300d9d3d884754cb2...

bors-servo commented 1 year ago

:sunny: Test successful - checks-github Approved by: jdm Pushing 235cf2b1c7a25bdac61b240300d9d3d884754cb2 to master...