Closed NickSpag closed 4 years ago
@bors-servo: r+
:pushpin: Commit 04787f1 has been approved by pcwalton
:hourglass: Testing commit 04787f15149db06aa6faa7bf3291b9c959f8ca75 with merge a51176a3ba794df22d7951d55fc3a1c22c2f690b...
Looks great, thanks!
:sunny: Test successful - checks-travis Approved by: pcwalton Pushing a51176a3ba794df22d7951d55fc3a1c22c2f690b to master...
Background
This PR exposes the c api to the EmbeddedResourceLoader, to prevent some of the issues mentioned here.
Approach
PFFilesystemResourceLoaderLocate
and simply exposed the ERL's new and boxed it in the ResourceLoaderWrapperCreate
terminology in the signature to match the rest of the api where a new() is calledNotes
Let me know if I misinterpreted anything or if there are any changes, stylistic or otherwise, that you'd prefer. Thanks!