Passing actual color in fill attribute

servo / pathfinder

A fast, practical GPU rasterizer for fonts and vector graphics

Apache License 2.0

3.56k stars 198 forks source link

Closed bellwether-softworks closed 3 years ago

bellwether-softworks commented 3 years ago

Presently, when serializing to SVG, the fill attribute is being populated with a PaintId identifier, e.g.:

<path fill="PaintId(1)" d="M 0 0 L 431.8 0 L 431.8 279.4 L 0 279.4 z" />

This PR instead utilizes the base color, which results in the following alternative output:

<path fill="#ffffff" d="M 0 0 L 431.8 0 L 431.8 279.4 L 0 279.4 z" />

jdm commented 3 years ago

@bors-servo r+

bors-servo commented 3 years ago

:pushpin: Commit ca3edb7 has been approved by jdm

bors-servo commented 3 years ago

:hourglass: Testing commit ca3edb72a17e64af24f86564caf1ccd435be2638 with merge 512087d365bef64b769e76f40149c7d8bc37f4fa...

bors-servo commented 3 years ago

:sunny: Test successful - checks-travis Approved by: jdm Pushing 512087d365bef64b769e76f40149c7d8bc37f4fa to master...