Closed jonaspleyer closed 4 months ago
@jdm @mrobinson @s3bk , could you take a look at this please.
I noticed when https://github.com/zowens/crc32c/pull/52 did this, they also re-added another feature for aarch64, see https://github.com/zowens/crc32c/pull/54
I have just confirmed that the build also works when including the following flags:
#![cfg_attr(all(target_arch = "aarch64", nightly), feature(stdarch_arm_crc32))]
I also upated the PR accordingly.
I would say to merge this and see if it breaks for some architecture later?
I am going to merge this and then make a PR to fix the pdf stuff.
Problem
I was recently compiling the plotters crate with the nigthly compiler and got the following build error:
My nightly compiler is
Solution
It seems that the feature flag
stdsimd
is not present in the nightly compiler anymore. This patch very small patch is able to fix my problem and the package still compileswith this stable compiler:
Comments
I am aware that this patch affects stable upstream and do not know about the internals of this package. This patch might be obsolete depending on if the nightly version changes again in the future. I am looking forward on Feedback regarding this issue and this PR. This may also be a nightly compiler error but I do not know how to check this.