servo / pathfinder

A fast, practical GPU rasterizer for fonts and vector graphics
Apache License 2.0
3.52k stars 198 forks source link

Compile Error on nightly, unknown feature `stdsimd` #550

Closed ripytide closed 2 months ago

ripytide commented 4 months ago
error[E0635]: unknown feature `stdsimd`
  --> /pathfinder_simd-0.5.2/src/lib.rs:12:49
   |
12 | #![cfg_attr(pf_rustc_nightly, feature(simd_ffi, stdsimd))]
   |                                                 ^^^^^^^

This is similar to the error in the ahash crate: https://github.com/tkaitchuck/aHash/issues/200

jayvdb commented 4 months ago

The commit removing stdsimd is https://github.com/rust-lang/rust/commit/ea37e8091fe87ae0a7e204c034e7d55061e56790 Relevant tracking issues? https://github.com/rust-lang/rust/issues/27731 and https://github.com/rust-lang/rust/issues/48556

jayvdb commented 4 months ago

https://github.com/servo/pathfinder/pull/548 fixes this

DraftedDev commented 4 months ago

I still get the error when trying to compile pathfinder_geometry with the pf-text feature.

jayvdb commented 4 months ago

https://github.com/servo/pathfinder/blob/main/geometry/Cargo.toml does not have a pf-text feature.

Could you provide a lot of the build failure that you are seeing?

DraftedDev commented 4 months ago

Sorry, I meant pathfinder_canvas. But using the patches described in #313 helps. (though I still get an ugly linker error)

jayvdb commented 4 months ago

hmm That feature compiled file for me on stable and nightly, when building on main

DraftedDev commented 4 months ago

I should probably re-open #313 again. But thanks anyways :D

attila-lin commented 4 months ago

Will we have a new release?

DraftedDev commented 4 months ago

Will we have a new release?

I think that's for another issue, but it doesn't look like the next release is coming soon. This project is being SLOWLY developed and if we are lucky, there may be a commit within the next week.

avhz commented 4 months ago

This issue seems to be preventing my docs from being built on docs.rs after a publish.

avhz commented 4 months ago

Any updates on this ?

avhz commented 3 months ago

Bumping. If the fix is pushed, can a bug fix release be pushed to crates.io ?

aujxn commented 3 months ago

This is also causing my builds to fail and is deep into my dependency graphs. If I switch from nightly to stable it fixes it but I need nightly features

atouchet commented 2 months ago

A new version of pathfinder_simd was published. This should be fixed now.