search

servo / rust-azure

Rust bindings to mozilla-central's graphics abstraction layer
Mozilla Public License 2.0
56 stars 59 forks source link

Update freetype. #253

Closed emilio closed 7 years ago

emilio commented 7 years ago

r? @jdm (or anyone else)

This change is Reviewable

jdm commented 7 years ago

We probably need to fix Travis unless we merge manually.

emilio commented 7 years ago

Gah, that's annoying, will see if I can address it.

emilio commented 7 years ago

Traced this down to a change in x11's build that now require a newer version, opened https://github.com/Daggerbot/x11-rs/issues/57

emilio commented 7 years ago

I guess it's fine to merge manually until that's fixed given this is a pretty unrelated change?

emilio commented 7 years ago

(I can also downgrade x11, of course, but then we need to re-upgrade it).

jdm commented 7 years ago

I would rather have a successful build than merge blindly, given that freetype 0.1.3 continues to work (as demonstrated in the other PR that merged).

emilio commented 7 years ago

@jdm The other PR merged without a new build.

@bors-servo try

bors-servo commented 7 years ago

:hourglass: Trying commit 4394009 with merge 3fe87f4...

emilio commented 7 years ago

Doing a try run because of https://github.com/Daggerbot/x11-rs/issues/57#issuecomment-272717581

bors-servo commented 7 years ago

:sunny: Test successful - status-travis

emilio commented 7 years ago

There you go, r? @jdm

jdm commented 7 years ago

@bors-servo: r+

bors-servo commented 7 years ago

:pushpin: Commit fa004b3 has been approved by jdm

bors-servo commented 7 years ago

:hourglass: Testing commit fa004b3 with merge d5aa525...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis