search

servo / rust-azure

Rust bindings to mozilla-central's graphics abstraction layer
Mozilla Public License 2.0
56 stars 59 forks source link

Implement Ellipse API #272

Closed joone closed 7 years ago

joone commented 7 years ago

Bug: https://github.com/servo/servo/issues/17598

The ellipse API was added as public API of Azure and the Arc method was updated to deal with the ellipse API.

This change is Reviewable

joone commented 7 years ago

How can we build a test case and run it?

joone commented 7 years ago

Here is another patch for Servo side: https://github.com/joone/servo/commit/427a24a2ae523a9704bc7560b05e551a886cd9ef

jdm commented 7 years ago

We will either need to upstream the changes and update from upstream once that happens, or add a local .patch file that contains the changes to libazure to make it easier to update from upstream later.

jdm commented 7 years ago

Note: upstream at https://hg.mozilla.org/mozilla-central/file/tip/gfx/2d

joone commented 7 years ago

jdm@ how can I add a local .patch file to libazure?

jdm commented 7 years ago

Create a file that contains the diff of the changes to libazure, and add it to a directory named patches

joone commented 7 years ago

@jdm I created a patch in my commit, but the patch was not applied to libazure during the build. Could you take a look at the commit?

jdm commented 7 years ago

Right, there's no automated way to apply patches. Your changes still need to be applied to the source files directly, as well. Adding the patch file means that we won't lose track of them and overwrite them whenever we update from upstream in the future.

joone commented 7 years ago

@jdm, okay, I've updated the patch. Thanks!

jdm commented 7 years ago

Sorry, one last change - can we move the patches directory out of libazure? Right now it's easy to end up overwriting it. Please update the version in Cargo.toml to be 0.21.0, too.

joone commented 7 years ago

@jdm, I've done with the update.

jdm commented 7 years ago

@bors-servo: r+ Thanks!

bors-servo commented 7 years ago

:pushpin: Commit 648e112 has been approved by jdm

bors-servo commented 7 years ago

:hourglass: Testing commit 648e112bbf15a8b741553300a422381c2971b69e with merge a2351f23af51dac2bd091638e84232cc4bedf55b...

bors-servo commented 7 years ago

:sunny: Test successful - status-travis Approved by: jdm Pushing a2351f23af51dac2bd091638e84232cc4bedf55b to master...