search

servo / rust-azure

Rust bindings to mozilla-central's graphics abstraction layer
Mozilla Public License 2.0
56 stars 59 forks source link

Make the Skia GL backend opt-out. #300

Closed jdm closed 5 years ago

jdm commented 5 years ago

Servo doesn't actually use the GL support and it makes it harder to build for non-GL platforms.

This change is Reviewable

jdm commented 5 years ago

Depends on https://github.com/servo/skia/pull/177.

jdm commented 5 years ago

r? @paulrouget

paulrouget commented 5 years ago

This compiles. But when compiling servo with this version of azure (with no default features), I'm getting linking errors, like:

  = note: lld-link.exe: error: undefined symbol: ?CreateFromName@SkTypeface@@SAPEAV1@QEBDW4Style@1@@Z
          >>> referenced by c:\msys64\home\paul\git\rust-azure\libazure\scaledfontskia.cpp:44
          >>>               libazure-4b9413b847428edf.rlib(ScaledFontSkia.obj):($LN40)

          lld-link.exe: error: undefined symbol: ?CreateFromStream@SkTypeface@@SAPEAV1@PEAVSkStream@@@Z
          >>> referenced by c:\msys64\home\paul\git\rust-azure\libazure\scaledfontskia.cpp:51
          >>>               libazure-4b9413b847428edf.rlib(ScaledFontSkia.obj):($LN7)
jdm commented 5 years ago

@paulrouget See if the situation is improved with the latest changes from both rust-azure and skia PRs.

paulrouget commented 5 years ago

Most of errors are gone. Left with:

  = note: lld-link.exe: error: undefined symbol: __imp_wglGetCurrentContext
          >>> referenced by libskia-62261fbc6ffb37af.rlib(GrGLCreateNativeInterface_win.obj):($LN25)

          lld-link.exe: error: undefined symbol: __imp_wglGetProcAddress
          >>> referenced by libskia-62261fbc6ffb37af.rlib(GrGLCreateNativeInterface_win.obj):(?win_get_gl_proc@@YAP6AXXZPEAXQEBD@Z)
bors-servo commented 5 years ago

:umbrella: The latest upstream changes (presumably #301) made this pull request unmergeable. Please resolve the merge conflicts.