Open RazrFalcon opened 5 years ago
I generally dislike having generated files in a source repository. And these are build-dependencies, not part of the final binary.
Yes, but they are slowing down the build process.
Happy to take a patch here as long as it's well documented how to tweak it as needed.
Specially since those colors are not gonna change any time soon...
phf_codegen
is a pretty big dependency and colors will not change from build to build, so maybe it's better to keep the colors map as a "prebuilt" file? Something like this.The source of the problem:
It's like 20 dependencies just to build a phf map, that never changes.