search

servo / rust-fnv

Fowler–Noll–Vo hash function
https://doc.servo.org/fnv/
Apache License 2.0
338 stars 28 forks source link

Should this code's licensing match the Rust project's? #29

Open anp opened 2 years ago

anp commented 2 years ago

We recently reviewed this crate which is vendored in Fuchsia, and noticed that the implementation was copied from rustc originally, but the licensing metadata does not fully reflect this. The copyright in this repo's MIT license is different from the one in rust-lang/rust's COPYRIGHT file, and the Cargo.toml file's authors metadata is also different.

Manishearth commented 2 years ago

cc @jdm we probably should update it to include a dual attribution?

jdm commented 2 years ago

I would merge a pull request that did that.

atouchet commented 2 years ago

This crate is already dual licensed as Apache-2.0 / MIT. What exactly needs to be changed here?

Manishearth commented 2 years ago

I think the thing needed is for the attribution to include the Rust Project Developers.