search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 117 forks source link

Replace `i8` with `libc::c_char` #179

Closed akosthekiss closed 9 years ago

akosthekiss commented 9 years ago

It is definitely suboptimal to manually edit autogenerated code and surely incomplete but, at least, gets servo build on platforms where char is unsigned (e.g., on aarch64).

It would be great if a future version of bindgen could generate libc::c_char at the right places.

Review on Reviewable

jdm commented 9 years ago

cc @michaelwu

michaelwu commented 9 years ago

Now fixed in bindgen++ https://github.com/michaelwu/rust-bindgen/commit/1c10ec45ab7eefe232177c217f23482fd29bce81

r=me for this PR which will cover things until the next bindings update.

jdm commented 9 years ago

@bors-servo: r+

bors-servo commented 9 years ago

:pushpin: Commit b5e8488 has been approved by jdm

bors-servo commented 9 years ago

:hourglass: Testing commit b5e8488 with merge b8483df...

bors-servo commented 9 years ago

:sunny: Test successful - cargo-linux, cargo-mac