search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Add glue for header-inlined typed array functions that cause linker e… #180

Closed jdm closed 8 years ago

jdm commented 9 years ago

…rrors on OS X.

Review on Reviewable

Ms2ger commented 9 years ago

LGTM, but maybe @michaelwu has comments on ways to avoid this.

michaelwu commented 9 years ago

There isn't any support for things in headers that aren't exported. Some inline functions are exported, but only as part of a class/struct definition that is exported. bindgen++ doesn't have support for non-exported things at the moment. I've had some thoughts about adding support for those things, but I haven't thought too deeply about it. At any rate, it's probably not going to be supported by the next bindings update, so this is fine.

metajack commented 8 years ago

pinging @jdm Seems like this needs code changes.