search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Remove symbols that are either missing or hidden in libmozjs #181

Closed larsbergstrom closed 9 years ago

larsbergstrom commented 9 years ago

There is one mangling-related removal (of va_args-related functions), but these were never called and I'm not convinced they would have worked on any platform except for Linux 64 bit.

r? @Ms2ger @michaelwu

Review on Reviewable

larsbergstrom commented 9 years ago

These symbols only caused a problem on Android, where all of the symbols are force-resolved at startup. On other platforms, we have dynamic linking working, so the fact that these symbols don't exist doesn't cause a failure because we never attempt to call the Rust stub functions.

michaelwu commented 9 years ago

r=me. This should be a useful reference when I try to fix this issue in bindgen++.

larsbergstrom commented 9 years ago

@bors-servo: r=michaelwu

bors-servo commented 9 years ago

:pushpin: Commit e70caf7 has been approved by michaelwu

bors-servo commented 9 years ago

:hourglass: Testing commit e70caf7 with merge e1a8c46...

bors-servo commented 9 years ago

:sunny: Test successful - cargo-linux, cargo-mac