search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Fix signature of JS_BufferIsCompilableUnit #192

Closed tschneidereit closed 8 years ago

tschneidereit commented 9 years ago

r? @larsbergstrom

Review on Reviewable

michaelwu commented 9 years ago

https://gist.github.com/michaelwu/a9525f07112a8224a540 is the latest output from bindgen. size_t is handled correctly now.

Replacing size_t with usize sounds good - I'll try that next time, though I think we should stick to size_t for now for consistency.

michaelwu commented 9 years ago

This should be fixed by the bindings update.

michaelwu commented 8 years ago

https://github.com/servo/rust-mozjs/pull/198 will fix this.