servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Manual fix to some function signatures to ensure correct usage of C characters #193

Closed akosthekiss closed 9 years ago

akosthekiss commented 9 years ago

libc::c_char is not always i8, can be unsigned on some platforms (e.g., on AArch64).

Review on Reviewable

akosthekiss commented 9 years ago

Similar to #179 cc @michaelwu

Ms2ger commented 9 years ago

@bors-servo r+

bors-servo commented 9 years ago

:pushpin: Commit 78173c6 has been approved by Ms2ger

bors-servo commented 9 years ago

:hourglass: Testing commit 78173c6 with merge 2a970d9...

bors-servo commented 9 years ago

:sunny: Test successful - cargo-linux, cargo-mac