search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 117 forks source link

Check the result of JS_DefineFunction in the example. #199

Closed Ms2ger closed 9 years ago

Ms2ger commented 9 years ago

Review on Reviewable

jdm commented 9 years ago

I think this will be easier to read as:

let func = JS_DefineFunction(...);
assert!(!func.is_null());
jdm commented 9 years ago

@bors-servo: r+

bors-servo commented 9 years ago

:pushpin: Commit 70c1273 has been approved by jdm

bors-servo commented 9 years ago

:hourglass: Testing commit 70c1273 with merge d368670...

bors-servo commented 9 years ago

:sunny: Test successful - travis