search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Mark unsafe functions unsafe. #207

Closed Ms2ger closed 8 years ago

Ms2ger commented 8 years ago

All of those can trivially be made to crash by passing an invalid JSContext pointer.

Review on Reviewable

metajack commented 8 years ago

@bors-servo r+

Bonus readability!

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from the review on Reviewable.io

bors-servo commented 8 years ago

:pushpin: Commit 17f3fd5 has been approved by metajack

bors-servo commented 8 years ago

:hourglass: Testing commit 17f3fd5 with merge 8fabaf8...

bors-servo commented 8 years ago

:sunny: Test successful - travis