servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

Rename CallArgs::{get, get_mut} to {index, index_mut}. #220

Closed Ms2ger closed 8 years ago

Ms2ger commented 8 years ago

CallArgs::get exists in C++ with different semantics. It is confusing to have it exist in this form.

Fixes #219.

Review on Reviewable

jdm commented 8 years ago

@bors-servo: r+

bors-servo commented 8 years ago

:pushpin: Commit 288af44 has been approved by jdm

bors-servo commented 8 years ago

:hourglass: Testing commit 288af44 with merge 6bfe259...

bors-servo commented 8 years ago

:sunny: Test successful - travis