servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 117 forks source link

Set the native stack quota per Gecko's defaults to defend against JavaScript stack overflows. #249

Closed pcwalton closed 8 years ago

pcwalton commented 8 years ago

Addresses servo/servo#10229.

r? @jdm


This change is Reviewable

jdm commented 8 years ago

What about adding a test to src/tests.rs that initializes a basic global object, then evaluates function f() { f() }; f() and asserts that the return value is 0?

pcwalton commented 8 years ago

Sure, sounds like a good idea.

pcwalton commented 8 years ago

Test added. r? @jdm

jdm commented 8 years ago

@bors-servo: r+

bors-servo commented 8 years ago

:pushpin: Commit e297eee has been approved by jdm

bors-servo commented 8 years ago

:hourglass: Testing commit e297eee with merge 2a5c60a...

bors-servo commented 8 years ago

:sunny: Test successful - travis