search

servo / rust-mozjs

DEPRECATED - moved to servo/mozjs instead.
Mozilla Public License 2.0
293 stars 122 forks source link

start tidying #255

Closed edunham closed 7 years ago

edunham commented 8 years ago

for https://github.com/servo/servo/issues/10636

Some license recognition failures are waiting on https://github.com/servo/servo/pull/10721 to land.

There are 214 lines over 120 characters in this project, many of which I don't think there's a good way to shorten. Should I update tidy to make the line length check optional?

This change is Reviewable

tschneidereit commented 8 years ago

Note that the jsapi_* files are auto-generated. I don't think it makes too much sense to tidy them.

jdm commented 8 years ago

Making it possible for tidy to read a per-repo config file that can ignore certain files might be the best way forward.

metajack commented 8 years ago

Does it make sense for it just to read .gitignore?

jdm commented 8 years ago

No, because our bindgen-generated files aren't in that.

metajack commented 8 years ago

Aren't bindgen generated files generated out of the source tree somewhere under target/? target/ is certainly in .gitignore.

jdm commented 8 years ago

No, they're checked into the main repository. We don't run bindgen on every build.

jdm commented 8 years ago

Note how big this PR is for why this is a thing to be concerned about :)

bors-servo commented 8 years ago

:umbrella: The latest upstream changes (presumably #257) made this pull request unmergeable. Please resolve the merge conflicts.

jdm commented 7 years ago

Closing due to lack of activity.